Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

36C3 #80

Closed
wants to merge 18 commits into from
Closed

36C3 #80

wants to merge 18 commits into from

Conversation

saerdnaer
Copy link
Member

No description provided.

saerdnaer and others added 17 commits October 25, 2019 18:21
merge with andies relive branch by cherrypick 1/x
recovery from ticket module changes introduced by merge with foss4g changes
merge with andies PR 2/x
fixed some exceptions with wrong except
fixed possible var access before set
improve readablilty of test data
most of the changes necessary for relive are done now but meta ticket handling needs some work.
restructured some code to prepare further changes
@saerdnaer saerdnaer marked this pull request as ready for review December 23, 2019 14:31
@saerdnaer
Copy link
Member Author

@derpeter I think we have to add an else: in line 350, otherwise new events will not be created... – but also have a look at idea #81.

# call voctoweb api
# check if the ticket already contains an event id
if self.t.voctoweb_event_id:
# check the public API if voctoweb knows this event before patching it
try:
r = requests.get(url[:-3] + "public/events/" + self.t.voctoweb_event_id)
except requests.exceptions.BaseHTTPError as e_:
raise VoctowebException("error while checking event id with public API") from e_
if r.status_code == 200:
try:
r = requests.patch(url, headers=headers, data=json.dumps(payload))
except requests.exceptions.BaseHTTPError as e_:
raise VoctowebException("error while patching event") from e_
else:
raise VoctowebException("Event id from ticket is not known to voctoweb. Something is out of sync")
try:
r = requests.post(url, headers=headers, data=json.dumps(payload))
except requests.exceptions.RetryError as e:
raise VoctowebException("Error during creation of event: " + str(e)) from e
return r

@voc-mng voc-mng force-pushed the merges-and-fixes-for-36c3 branch from fc388c5 to 16a2f3c Compare December 27, 2019 15:24
@saerdnaer saerdnaer closed this Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants