add support for AJA capture cards #353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Can you please add some documentation to |
|
Updated the documentation, and added a note on using the card as a mix output as well. |
|
Looks good, will give it a test soon :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly forked from the decklink source, but I switched it to using fstrings everywhere to make it (in my opinion) easier to read, and also added a use of the walrus (
:=) operator.Note: the config property
video_modeactually maps to ajasrc'svideo-format; this is for closer alignment with the decklink source. There are a few other properties that could probably do with being exposed.devicecurrently defaults to the empty string, which will fail if used. We should maybe default it to?, which is a magic string that makes the AJA SDK output the list of attached devices (and their serial numbers, which are used as device identifiers), and then quit.