feat(json-schema): add type on Reference, implements #144

voc · Dec 11, 2024 · f5141cf · f5141cf
1 parent 1dc5492
commit f5141cf
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 5 deletions.
diff --git a/validator/json/schema.json b/validator/json/schema.json
@@ -292,17 +292,19 @@
         },
         "links": {
           "type": "array",
-          "items": {},
-          "$comment": "// TODO: string vs object"
+          "items": {
+            "$ref": "#/definitions/Reference"
+          }
         },
         "feedback_url": {
           "type": "string",
           "format": "uri"
         },
         "attachments": {
           "type": "array",
-          "items": {},
-          "$comment": "// TODO: string vs object"
+          "items": {
+            "$ref": "#/definitions/Reference"
+          }
         },
         "answers": {
           "type": "array",
@@ -474,6 +476,36 @@
       "type": "string",
       "examples": ["00:30", "01:30"],
       "pattern": "^[0-9]+:[0-9]{2}$"
+    },
+    "Reference": {
+      "title": "Link or Attachment",
+      "type": "object",
+      "additionalProperties": false,
+      "properties": {
+        "type": {
+          "type": "string",
+          "enum": [
+            "slides",
+            "paper",
+            "web",
+            "blog",
+            "article",
+            "media",
+            "related",
+            "activitypub"
+          ]
+        },
+        "url": {
+          "type": "string",
+          "format": "uri"
+        },
+        "title": {
+          "type": "string"
+        }
+      },
+      "required": [
+        "url"
+      ]
     }
   }
-}
+}
diff --git a/validator/submission-json/schema.json b/validator/submission-json/schema.json
@@ -214,6 +214,19 @@
             "type": "object",
             "additionalProperties": false,
             "properties": {
+                "type": {
+                    "type": "string",
+                    "enum": [
+                        "slides",
+                        "paper",
+                        "web",
+                        "blog",
+                        "article",
+                        "media",
+                        "related",
+                        "activitypub"
+                    ]
+                },
                 "url": {
                     "type": "string",
                     "format": "uri"