Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change udmrepo config file location to tmp #8602

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

Lyndon-Li
Copy link
Contributor

@Lyndon-Li Lyndon-Li commented Jan 13, 2025

Fix issue #8067, add tmp folder (/tmp for linux, C:\Windows\Temp for Windows) as an alternative of udmrepo's config file location

@Lyndon-Li Lyndon-Li force-pushed the change-udmrepo-config-to-tmp branch from 6abe9ef to 36b2ac1 Compare January 13, 2025 03:14
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.18%. Comparing base (46b8a31) to head (e79dbb8).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
pkg/repository/udmrepo/repo_options.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8602      +/-   ##
==========================================
- Coverage   59.19%   59.18%   -0.02%     
==========================================
  Files         370      370              
  Lines       39658    39759     +101     
==========================================
+ Hits        23477    23531      +54     
- Misses      14696    14731      +35     
- Partials     1485     1497      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li Lyndon-Li marked this pull request as ready for review January 13, 2025 05:07
kaovilai
kaovilai previously approved these changes Jan 13, 2025
@Lyndon-Li Lyndon-Li force-pushed the change-udmrepo-config-to-tmp branch from 5780538 to e79dbb8 Compare January 13, 2025 07:54
@Lyndon-Li Lyndon-Li requested a review from kaovilai January 13, 2025 07:55
@Lyndon-Li Lyndon-Li merged commit 094ba59 into vmware-tanzu:main Jan 13, 2025
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants