chore: enable unused-parameter from revive

Signed-off-by: Matthieu MOREL <[email protected]>

.golangci.yaml

@@ -280,7 +280,6 @@ linters-settings:
       - name: unreachable-code
         disabled: false
       - name: unused-parameter
-        disabled: true
       - name: use-any
         disabled: true
       - name: var-declaration

internal/hook/item_hook_handler.go

@@ -308,12 +308,12 @@ func (h *DefaultItemHookHandler) HandleHooks(
 type NoOpItemHookHandler struct{}
 
 func (h *NoOpItemHookHandler) HandleHooks(
-	log logrus.FieldLogger,
-	groupResource schema.GroupResource,
-	obj runtime.Unstructured,
-	resourceHooks []ResourceHook,
-	phase HookPhase,
-	hookTracker *HookTracker,
+	_ logrus.FieldLogger,
+	_ schema.GroupResource,
+	_ runtime.Unstructured,
+	_ []ResourceHook,
+	_ HookPhase,
+	_ *HookTracker,
 ) error {
 	return nil
 }

internal/hook/wait_exec_hook_handler.go

@@ -220,7 +220,7 @@ func (e *DefaultWaitExecHookHandler) HandleHooks(
 		UpdateFunc: func(_, newObj interface{}) {
 			handler(newObj)
 		},
-		DeleteFunc: func(obj interface{}) {
+		DeleteFunc: func(_ interface{}) {
 			err := fmt.Errorf("pod %s deleted before all hooks were executed", kube.NamespaceAndName(pod))
 			log.Error(err)
 			cancel()

internal/hook/wait_exec_hook_handler_test.go

@@ -42,7 +42,7 @@ type fakeListWatchFactory struct {
 	lw cache.ListerWatcher
 }
 
-func (f *fakeListWatchFactory) NewListWatch(ns string, selector fields.Selector) cache.ListerWatcher {
+func (f *fakeListWatchFactory) NewListWatch(_ string, _ fields.Selector) cache.ListerWatcher {
 	return f.lw
 }
 

internal/storage/storagelocation.go

@@ -94,7 +94,7 @@ func ListBackupStorageLocations(ctx context.Context, kbClient client.Client, nam
 	return locations, nil
 }
 
-func GetDefaultBackupStorageLocations(ctx context.Context, kbClient client.Client, namespace string) (*velerov1api.BackupStorageLocationList, error) {
+func GetDefaultBackupStorageLocations(_ context.Context, kbClient client.Client, namespace string) (*velerov1api.BackupStorageLocationList, error) {
 	locations := new(velerov1api.BackupStorageLocationList)
 	defaultLocations := new(velerov1api.BackupStorageLocationList)
 	if err := kbClient.List(context.Background(), locations, &client.ListOptions{Namespace: namespace}); err != nil {

pkg/backup/actions/backup_pv_action.go

@@ -48,7 +48,7 @@ func (a *PVCAction) AppliesTo() (velero.ResourceSelector, error) {
 
 // Execute finds the PersistentVolume bound by the provided
 // PersistentVolumeClaim, if any, and backs it up
-func (a *PVCAction) Execute(item runtime.Unstructured, backup *v1.Backup) (runtime.Unstructured, []velero.ResourceIdentifier, error) {
+func (a *PVCAction) Execute(item runtime.Unstructured, _ *v1.Backup) (runtime.Unstructured, []velero.ResourceIdentifier, error) {
 	a.log.Info("Executing PVCAction")
 
 	pvc := new(corev1api.PersistentVolumeClaim)

pkg/backup/actions/csi/volumesnapshot_action.go

@@ -270,7 +270,7 @@ func (p *volumeSnapshotBackupItemAction) Name() string {
 
 func (p *volumeSnapshotBackupItemAction) Progress(
 	operationID string,
-	backup *velerov1api.Backup,
+	_ *velerov1api.Backup,
 ) (velero.OperationProgress, error) {
 	progress := velero.OperationProgress{}
 	if operationID == "" {
@@ -360,8 +360,8 @@ func (p *volumeSnapshotBackupItemAction) Progress(
 
 // Cancel is not implemented for VolumeSnapshotBackupItemAction
 func (p *volumeSnapshotBackupItemAction) Cancel(
-	operationID string,
-	backup *velerov1api.Backup,
+	_ string,
+	_ *velerov1api.Backup,
 ) error {
 	// CSI Specification doesn't support canceling a snapshot creation.
 	return nil

pkg/backup/actions/csi/volumesnapshotclass_action.go

@@ -53,7 +53,7 @@ func (p *volumeSnapshotClassBackupItemAction) AppliesTo() (
 // items any snapshot lister secret that may be referenced in its annotations.
 func (p *volumeSnapshotClassBackupItemAction) Execute(
 	item runtime.Unstructured,
-	backup *velerov1api.Backup,
+	_ *velerov1api.Backup,
 ) (
 	runtime.Unstructured,
 	[]velero.ResourceIdentifier,
@@ -103,16 +103,16 @@ func (p *volumeSnapshotClassBackupItemAction) Name() string {
 
 // Progress is not implemented for VolumeSnapshotClassBackupItemAction
 func (p *volumeSnapshotClassBackupItemAction) Progress(
-	operationID string,
-	backup *velerov1api.Backup,
+	_ string,
+	_ *velerov1api.Backup,
 ) (velero.OperationProgress, error) {
 	return velero.OperationProgress{}, nil
 }
 
 // Cancel is not implemented for VolumeSnapshotClassBackupItemAction
 func (p *volumeSnapshotClassBackupItemAction) Cancel(
-	operationID string,
-	backup *velerov1api.Backup,
+	_ string,
+	_ *velerov1api.Backup,
 ) error {
 	return nil
 }

pkg/backup/actions/csi/volumesnapshotcontent_action.go

@@ -117,16 +117,16 @@ func (p *volumeSnapshotContentBackupItemAction) Name() string {
 
 // Progress is not implemented for VolumeSnapshotContentBackupItemAction.
 func (p *volumeSnapshotContentBackupItemAction) Progress(
-	operationID string,
-	backup *velerov1api.Backup,
+	_ string,
+	_ *velerov1api.Backup,
 ) (velero.OperationProgress, error) {
 	return velero.OperationProgress{}, nil
 }
 
 // Cancel is not implemented for VolumeSnapshotContentBackupItemAction.
 func (p *volumeSnapshotContentBackupItemAction) Cancel(
-	operationID string,
-	backup *velerov1api.Backup,
+	_ string,
+	_ *velerov1api.Backup,
 ) error {
 	// CSI Specification doesn't support canceling a snapshot creation.
 	return nil

pkg/backup/actions/pod_action.go

@@ -47,7 +47,7 @@ func (a *PodAction) AppliesTo() (velero.ResourceSelector, error) {
 // Execute scans the pod's spec.volumes for persistentVolumeClaim volumes and returns a
 // ResourceIdentifier list containing references to all of the persistentVolumeClaim volumes used by
 // the pod. This ensures that when a pod is backed up, all referenced PVCs are backed up too.
-func (a *PodAction) Execute(item runtime.Unstructured, backup *v1.Backup) (runtime.Unstructured, []velero.ResourceIdentifier, error) {
+func (a *PodAction) Execute(item runtime.Unstructured, _ *v1.Backup) (runtime.Unstructured, []velero.ResourceIdentifier, error) {
 	a.log.Info("Executing podAction")
 	defer a.log.Info("Done executing podAction")
 

pkg/backup/actions/remap_crd_version_action.go

@@ -57,7 +57,7 @@ func (a *RemapCRDVersionAction) AppliesTo() (velero.ResourceSelector, error) {
 }
 
 // Execute executes logic necessary to check a CustomResourceDefinition and inspect it for characteristics that necessitate saving it as v1beta1 instead of v1.
-func (a *RemapCRDVersionAction) Execute(item runtime.Unstructured, backup *v1.Backup) (runtime.Unstructured, []velero.ResourceIdentifier, error) {
+func (a *RemapCRDVersionAction) Execute(item runtime.Unstructured, _ *v1.Backup) (runtime.Unstructured, []velero.ResourceIdentifier, error) {
 	a.logger.Info("Executing RemapCRDVersionAction")
 
 	// This plugin is only relevant for CRDs retrieved from the v1 endpoint that were installed via the v1beta1

pkg/backup/actions/service_account_action.go

@@ -57,7 +57,7 @@ func (a *ServiceAccountAction) AppliesTo() (velero.ResourceSelector, error) {
 // Execute checks for any ClusterRoleBindings that have this service account as a subject, and
 // adds the ClusterRoleBinding and associated ClusterRole to the list of additional items to
 // be backed up.
-func (a *ServiceAccountAction) Execute(item runtime.Unstructured, backup *v1.Backup) (runtime.Unstructured, []velero.ResourceIdentifier, error) {
+func (a *ServiceAccountAction) Execute(item runtime.Unstructured, _ *v1.Backup) (runtime.Unstructured, []velero.ResourceIdentifier, error) {
 	a.log.Info("Running ServiceAccountAction")
 	defer a.log.Info("Done running ServiceAccountAction")