Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] Remove unnecessary weight initialization logic #11736

Merged
merged 2 commits into from
Jan 4, 2025

Conversation

DarkLight1337
Copy link
Member

There is no need for custom initialization as those weights will be overwritten by the model checkpoint anyway.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 4, 2025
@DarkLight1337 DarkLight1337 requested a review from Isotr0py January 4, 2025 11:56
Copy link

github-actions bot commented Jan 4, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@Isotr0py Isotr0py enabled auto-merge (squash) January 4, 2025 12:21
Signed-off-by: Isotr0py <[email protected]>
@youkaichao youkaichao disabled auto-merge January 4, 2025 15:46
@youkaichao youkaichao merged commit 65c0892 into vllm-project:main Jan 4, 2025
55 of 57 checks passed
@DarkLight1337 DarkLight1337 deleted the no-init branch January 4, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants