Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix precision error in LLaVA-NeXT feature size calculation #11735

Merged

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Jan 4, 2025

Our current calculations are done using Python floats which are in float64. In some edge cases, this may cause some inconsistency with HF's output. It seems that using float32 fixes the problem (not really sure why).

FIX #11704

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 4, 2025
@DarkLight1337 DarkLight1337 requested a review from ywang96 as a code owner January 4, 2025 11:51
@DarkLight1337 DarkLight1337 requested a review from Isotr0py January 4, 2025 11:51
Copy link

github-actions bot commented Jan 4, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@Isotr0py Isotr0py enabled auto-merge (squash) January 4, 2025 12:22
@youkaichao youkaichao disabled auto-merge January 4, 2025 15:45
@youkaichao youkaichao merged commit ba214df into vllm-project:main Jan 4, 2025
58 of 60 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-llava-next-processing branch January 4, 2025 16:18
@jianghuyihei
Copy link

Our current calculations are done using Python floats which are in float64. In some edge cases, this may cause some inconsistency with HF's output. It seems that using float32 fixes the problem (not really sure why).

FIX #11704

I am very sorry. I encountered a new problem after modifying the code. When the img size is (161, 184), an error message Attempted to assign 1128 = 1128 multimodal tokens to 1080 placeholders is reported. Should I open a new issue?

@DarkLight1337
Copy link
Member Author

Thanks for raising the issue! It should be fixed by #11772, please test again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Mismatch multi-modal placeholder of LLava-1.6-Mistral-7B
4 participants