Use height and width attrs when viewBox is not present #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the older SVGs that our application uses were exported were exported with a
height
andwidth
, but noviewBox
causing this plugin to break. The "correct" way to fix this problem would be to correct the SVG sources, but that was not something I wanted to pursue.As a non-perfect fallback for this situation, use the height and width attributes to construct a viewBox string so that compilation can continue.
I didn't add a test for this as I was reluctant to add another fixture to the repo, but can if you prefer.
I also thought about adding a console warning for SVGs missing the
viewBox
attr but thought that might just be annoying/heavy-handed.