Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search not found text #148

Merged
merged 7 commits into from
Jan 18, 2025
Merged

Improve search not found text #148

merged 7 commits into from
Jan 18, 2025

Conversation

wangbertha
Copy link
Collaborator

@wangbertha wangbertha commented Jan 15, 2025

Description

  • Clarify the results message in the building search when there are 0 matching buildings.
  • Add a link in the message that directs the user to and opens the Data Disclaimer.
  • Update package.json for new linting rules

Before:

400981342-a1b3c361-87cf-4cc7-b8a0-8b1152ae08fb

After:

Screenshot 2025-01-14 at 8 58 20 PM

Fixes #145 (issue)

Testing Instructions

  1. Search with an invalid building input to get to the "No results found!" search result
  2. Click on the "note on dataset" link to verify that the page navigates to and opens the Data Disclaimer

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for radiant-cucurucho-d09bae ready!

Name Link
🔨 Latest commit 8b2eea9
🔍 Latest deploy log https://app.netlify.com/sites/radiant-cucurucho-d09bae/deploys/678c093f5859ff000801a373
😎 Deploy Preview https://deploy-preview-148--radiant-cucurucho-d09bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wangbertha wangbertha requested a review from vkoves January 15, 2025 18:45
@vkoves
Copy link
Owner

vkoves commented Jan 18, 2025

I made a few minor tweaks, just adding some formatting and tweaking the verbiage a bit. Great work!

Screenshot from 2025-01-18 14-03-58

Copy link
Owner

@vkoves vkoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, awesome work! Great upgrade to add those package.json commands, we should make sure to update the README later with those new Prettier commands

@vkoves vkoves merged commit 30d30e3 into main Jan 18, 2025
6 of 7 checks passed
@vkoves vkoves deleted the improve-search-not-found-text branch January 18, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Search Not Found Text with Note On Covered Buildings
2 participants