Update Natural Gas to Fossil Gas In The UI #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So, started over. Updated the code I was working on to the current main branch, discarded old changed. This commit is just the static mentions of the word "Natural" changed to "Fossil". More difficult is preserving the .csv data structure as NaturalGasUse and then changing how it outputs everywhere.
Well, tried to implement a common function, but not getting anywhere. It's a start at least?
}
export function transformBuildingData(building: IBuilding): IBuilding {
return {
...building,
FossilGasUse: building.NaturalGasUse,
};
}
✅ Deploy Preview for radiant-cucurucho-d09bae ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
9 tasks
vkoves
reviewed
Dec 11, 2024
just pasted the source file from main branch
…://github.com/vkoves/electrify-chicago into issue-124-update-naturalgas-to-fossilgas-try2
sburnschicago
commented
Dec 11, 2024
|
Ok, I think we're all good, except for the static images in-power-chart.png and .webp in electrify-chicago/static. They refer to Natural gas in the graph, on the About page. |
|
Tests performed were building the site, going to every page, manually searching for Natural. Also loading some building and seeing if they loaded the correct replacement Fossil for Natural. |
vkoves
approved these changes
Dec 15, 2024
vkoves
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi Victor, I ended up creating a new branch to start with a more recent version of the code. First branch can be deleted?
This one has no changes to the data source, just changes to the static site where Natural Gas was mentioned.
Took another effort at editing the NaturalGasUse as it comes from the data source and displays on the site, but seems to be beyond me. In common_functions.vue was a start on it.
Seems that if the data source can't be changed, then there would need to be a transformation step in between, but only for where the data is displayed?
Resolves #124
Testing Instructions
Please describe the tests/QA that you did to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
Checklist:
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
Didn't seem necessary - only word change on the front-end
However, for transformation steps, documentation sounds great.
I have added tests that prove my fix is effective or that my feature works
Website loads fine.
New and existing unit tests pass locally with my changes