Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description: Linting and CI Setup for ROS 2 Package
Summary
This Pull Request introduces several enhancements to the CI pipeline, code quality checks, and ROS 2 node updates for the
softrobots_teleop
package. The following linters and tools have been configured to automatically run during pull requests and manual workflows:Linters Configured
ROS 2 Node Changes
PointCloudProcessor
node has been updated to load parameters directly from the ROS 2 parameter server instead of a YAML file. This change ensures that parameters such asred_threshold
,green_threshold
,blue_threshold
, and topics are dynamically loaded during runtime.load_parameters
method now uses ROS 2'sdeclare_parameter
andget_parameter
functions to fetch values from the ROS 2 parameters.launch.py
file was modified to pass these parameters directly to the node using theros__parameters
structure.RCLCPP_INFO
) to ensure proper parameter retrieval and debugging.CI Pipeline
Additionally, a GitHub Actions workflow named
colcon-action-runner
has been configured to automate the build, testing, and code coverage generation for thesoftrobots_teleop
package. The CI pipeline will:colcon
for ROS 2 workspaces.lcov
for C++ code andcoveragepy
for Python files.Workflow Configuration
rostooling/setup-ros-docker
with support for Ubuntu 22.04 (Jammy) and ROS 2 Humble.New Files Introduced
.github/workflows/lint.yml
: Configures the GitHub Actions workflow for running the various linters..github/workflows/colcon-action-runner.yml
: Configures the CI pipeline to build, test, and generate code coverage for the ROS 2 package.How to Test
Checklist
colcon
.Future Enhancements