Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vite-plugin-material-symbols #973

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RobinTail
Copy link

@RobinTail RobinTail commented Dec 4, 2024

Please make sure all the requirements are satisfied, otherwise the PR could be closed without further notice.

Checklist

  • Title as described.
  • Make sure you put things in the right category.
  • The description of your item should be a sentence with less than 24 words.
  • Avoid using links and parentheses in description.
  • Omit unnecessary words already provided in the context (e.g. for Vite, a Vite plugin).
  • Use proper case for terms (e.g. GitHub, TypeScript, ESLint, etc.)
  • When mentioning tools, omit versions whenever possible (e.g. use TypeScript instead of TypeScript 4.x, but keep Vue 2 and Vue 3 as they're incompatible).
  • When mentioning package names, use quotes whenever possible.
  • Always add your items to the end of a list.

Plugins/Tools

  • The plugin/tool is working with Vite 2.x and onward.
  • The project is Open Source.
  • The project follows the Vite Plugins Conventions.
  • The plugin uses Vite-specific hooks and can't be implemented as a Compatible Rollup Plugin.
  • The repo should be at least 30 days old.
  • The documentation is in English.
  • The project is active and maintained (inactive projects for longer 6 months will be removed without further notice).
  • The project accepts contributions.
  • Not a commercial product.

Starter Templates

  • The starter template is working with Vite 2.x and onward.
  • The documentation is in English.
  • The starter template must provide enough instructions / documentation about how to start up and what's included.
  • A screenshot or a live demo should be included.
  • The repo should be at least 30 days old.
  • Should be differentiable from the existing starter templates.

Apps/Websites

  • The website is available without errors and load in a reasonable amount of time.
  • The website must be Open Source and showing it's using Vite intensively.
  • The website is original and not too simple. For that reason, blogs and simple landing pages are rejected.

@RobinTail RobinTail marked this pull request as ready for review December 9, 2024 12:13
README.md Outdated Show resolved Hide resolved
@RobinTail
Copy link
Author

@Scrum , could you please run it again?

@Jogai
Copy link

Jogai commented Dec 10, 2024

But is it really awesome? I think this is generally a better solution: https://github.com/unplugin/unplugin-icons?tab=readme-ov-file#unplugin-icons

@Jogai
Copy link

Jogai commented Dec 10, 2024

Nothing personal. But an awesome list should be a 'curation, not a collection'. See the manifesto here: https://github.com/sindresorhus/awesome/blob/main/awesome.md#the-awesome-manifesto

Its just nowadays most of the awesome lists are just collections of entries that are submitted by the authors of those entries, and I'm worried it is detrimental to the quality of the lists.

The reason I spoke up this time is because there seem to be really good solutions for including icons already, and this one is not specifically doing something 'awesome'. Its a good fit for a relatively specific use case, and as such probably awesome for a minority of vite users.

So that's why I posed the question, mainly to the maintainers of the list because they are the judges.

This is not a critique of your package or the quality of it.

@Jogai
Copy link

Jogai commented Dec 10, 2024

This repo is suggested by Vite for listing Vite plugins made by community.

Ok, but that does not negate the point about curation vs collection.

I made a plugin that has nothing similar compared to unplugin-icons which does not even mention font-based Material Symbols.

It has a different approach, but there's two material symbol collections to choose from. I've got it setup in my project, and then it takes a couple of seconds to add a symbol from that collection in my app.

It's lightweight and solves the issue my company struggled to achieve for months. I made a solution that could help others having similar problem on both minimizing bundle size AND network payload.

Hey, I'm not trying to take away what you achieved for your company, nor do I know the environment and requirements you have to work with. What you came up with is probably the best fit for your project. Its just generally speaking that I think its kind of a niche solution to a general problem. Plus there's a runtime requirement on an external provider which is something to consider.

There is no and could not be a reliable measurement of awesomeness. Moreover, one awesome thing does not deny awesomeness of another, @Jogai

That is certainly true but words still carry meaning. If there is already a project out there that supports more build tools, more icons, etc. then I think its a legitimate question to ask if a new entry, that only partially covers what another tool does, should be included.
Plus, like you said, its linked by the vite project itself, making it an important resource. That's why I think lists like these have a responsibility to curate so visitors get pointed to options that give them greater flexibilty, are better supported etc.

But like I said, its up to the maintainers, which I'm not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants