-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vite-plugin-material-symbols
#973
base: master
Are you sure you want to change the base?
Add vite-plugin-material-symbols
#973
Conversation
@Scrum , could you please run it again? |
But is it really awesome? I think this is generally a better solution: https://github.com/unplugin/unplugin-icons?tab=readme-ov-file#unplugin-icons |
Nothing personal. But an awesome list should be a 'curation, not a collection'. See the manifesto here: https://github.com/sindresorhus/awesome/blob/main/awesome.md#the-awesome-manifesto Its just nowadays most of the awesome lists are just collections of entries that are submitted by the authors of those entries, and I'm worried it is detrimental to the quality of the lists. The reason I spoke up this time is because there seem to be really good solutions for including icons already, and this one is not specifically doing something 'awesome'. Its a good fit for a relatively specific use case, and as such probably awesome for a minority of vite users. So that's why I posed the question, mainly to the maintainers of the list because they are the judges. This is not a critique of your package or the quality of it. |
Ok, but that does not negate the point about curation vs collection.
It has a different approach, but there's two material symbol collections to choose from. I've got it setup in my project, and then it takes a couple of seconds to add a symbol from that collection in my app.
Hey, I'm not trying to take away what you achieved for your company, nor do I know the environment and requirements you have to work with. What you came up with is probably the best fit for your project. Its just generally speaking that I think its kind of a niche solution to a general problem. Plus there's a runtime requirement on an external provider which is something to consider.
That is certainly true but words still carry meaning. If there is already a project out there that supports more build tools, more icons, etc. then I think its a legitimate question to ask if a new entry, that only partially covers what another tool does, should be included. But like I said, its up to the maintainers, which I'm not. |
Checklist
for Vite
,a Vite plugin
).GitHub
,TypeScript
,ESLint
, etc.)TypeScript
instead ofTypeScript 4.x
, but keepVue 2
andVue 3
as they're incompatible).Plugins/Tools
Starter Templates
Apps/Websites