fix(core): conflicting resize logic when using non-default useDevicePixels

[Pessimistress]

Background

Canvas resize events are being responded to by two independent code paths:

• CanvasContext with autoResize: true sets up resize observer which calls resize without the correct useDevicePixels setting
• AnimationLoop with autoResizeDrawingBuffer: true checks canvas size before each render frame with the correct useDevicePixels setting

If the user sets useDevicePixels to a value that is not window.devicePixelRatio the canvas ends up getting resized twice to different dimensions.

Change List

• Disable autoResize when creating the context

[coveralls]

coverage: 91.705%. remained the same
when pulling 73b6e9f on x/context-resize
into f13b96e on master.

[ibgreen]

just some background.

• There is an improved ResizeObserver API in browsers which allows the canvas context's ResizeObserver to determine the actual device pixel size of the canvas.
• This hasn't been possible in the past, as CSS width * dpr is just an approximation (because of rounding errors) which can result in very noticeable and undesirable moire effects.
• I recommend reading https://webgpufundamentals.org/webgpu/lessons/webgpu-resizing-the-canvas.html if interested.

CanvasContext now adopts this new method (at the cost of reduced support for arbitrary user specified DPRs in useDevicePixelRatio).

Even if the app does not use CanvasContext auto resize, the resize observer should update the pixelSize field on the canvas context, so that the app has access to the perfect size information for its own resizing calculations.

Longer term, I would avoid relying on any residual resize logic in the AnimationLoop. It is duplicative and confusing if resize is done (differently) in two places.

[Pessimistress]

My take away from reviewing luma.gl branches and discussion with @ibgreen:

• CanvasContext's autoResize API will be the preferred way to handle resize, and AnimationLoop's autoResizeDrawingBuffer API will be deprecated
• luma.gl v9.2 significantly improves pixel size handling from v9.1
• As of the latest 9.1 alpha release, CanvasContextProps.autoResize cannot replace AnimationLoopProps.autoResizeDrawingBuffer, because resizeObserver is triggered outside of the render loop. This is intended to be fixed in 9.2 by the onResize callback.
• Without last-minute changes to this essential code path, I am still disabling autoResize in this PR, but changed the comment to note that this is temporary.

    return new AnimationLoop({
      device: deviceOrPromise,
-      useDevicePixels,                 // v9.1
-      autoResizeDrawingBuffer: !gl,    // v9.1
+      autoResizeDrawingBuffer: false,  // v9.2
      autoResizeViewport: false,

      deviceOrPromise = luma.createDevice({
        createCanvasContext: {
          canvas: this._createCanvas(props),
          useDevicePixels: this.props.useDevicePixels,
-          autoResize: false   // v9.1
+          autoResize: true    // v9.2
        }
      });

[felixpalmer]

Agree with the approach 👍