-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support MaskExtension with HeatmapLayer #7397
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layers should not have any knowledge of a particular extension. I believe that the transform (which generates the heatmap texture) is already created with the shader of the MaskExtension. The issue is that when the layer updates its module settings, parameters are only sent to the model that draws to screen, bypassing the transform.
This is difficult as the
I don't follow here, I'm not sure what change you want me to make |
Hello, this is still in progress? any estimation of release? Thanks. |
Hello, sorry for asking again, is there any forecast to release this fix? In my company we need to mask the heatmap layer at port level very accurately and it would be nice to know if we can count on it or look for another solution. Thanks! |
0a083b6
to
eb85da3
Compare
For #7184
Background
Screen.Recording.2022-11-10.at.14.12.13.mov
Due to the aggregation the mask extension wasn't working with the
HeatmapLayer
. This PoC works well, but it doesn't fit cleanly with the deck architecture. @Pessimistress could you give some input on:EffectManager
inAggregationLayer.getModuleParameters
weightsTransform
to execute after the mask is rendered. I couldn't find a way without adding thepostEffect
hookChange List
weightsTransform
&TriangleLayer
TODO