Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade React from 518d06d2-20241219 to 62208bee-20250102 #74468

Open
wants to merge 6 commits into
base: canary
Choose a base branch
from

Conversation

@ijjk
Copy link
Member

ijjk commented Jan 2, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-62208bee-20250102 Change
buildDuration 19.5s 17s N/A
buildDurationCached 16.1s 13.5s N/A
nodeModulesSize 416 MB 416 MB ⚠️ +38.5 kB
nextStartRea..uration (ms) 486ms 468ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-62208bee-20250102 Change
1187-HASH.js gzip 52.4 kB 52.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 52.8 kB 52.8 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 233 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-62208bee-20250102 Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-62208bee-20250102 Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-62208bee-20250102 Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-62208bee-20250102 Change
index.html gzip 524 B 524 B
link.html gzip 538 B 537 B N/A
withRouter.html gzip 520 B 520 B
Overall change 1.04 kB 1.04 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-62208bee-20250102 Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 206 kB 206 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-62208bee-20250102 Change
middleware-b..fest.js gzip 670 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-62208bee-20250102 Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 359 kB 359 kB ⚠️ +401 B
app-page-exp..prod.js gzip 129 kB 129 kB N/A
app-page-tur..prod.js gzip 142 kB 142 kB N/A
app-page-tur..prod.js gzip 137 kB 137 kB N/A
app-page.run...dev.js gzip 348 kB 348 kB N/A
app-page.run..prod.js gzip 125 kB 125 kB N/A
app-route-ex...dev.js gzip 37.5 kB 37.5 kB N/A
app-route-ex..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB N/A
app-route.ru..prod.js gzip 25.4 kB 25.4 kB N/A
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB N/A
Overall change 538 kB 538 kB ⚠️ +401 B
build cache
vercel/next.js canary vercel/next.js update/react/19.1.0-canary-62208bee-20250102 Change
0.pack gzip 2.08 MB 2.08 MB N/A
index.pack gzip 74.4 kB 73.6 kB N/A
Overall change 0 B 0 B
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
Diff for server.runtime.prod.js
failed to diff
Commit: 13cb5c5

@ijjk
Copy link
Member

ijjk commented Jan 2, 2025

Failing test suites

Commit: 13cb5c5

pnpm test-dev test/development/acceptance-app/hydration-error.test.ts

  • Error overlay for hydration errors in App router > should collapse and uncollapse properly when there are many frames
Expand output

● Error overlay for hydration errors in App router › should collapse and uncollapse properly when there are many frames

expect(received).toBe(expected) // Object.is equality

Expected: 4
Received: NaN

  788 |
  789 |     retry(async () => {
> 790 |       expect(await getRedboxTotalErrorCount(browser)).toBe(4)
      |                                                       ^
  791 |     })
  792 |
  793 |     const description = await session.getRedboxDescription()

  at toBe (development/acceptance-app/hydration-error.test.ts:790:55)
  at retry (lib/next-test-utils.ts:806:14)

Read more about building and testing Next.js in contributing.md.

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/app-dir/non-root-project-monorepo/non-root-project-monorepo.test.ts (PPR)

  • non-root-project-monorepo > import.meta.url > should work during RSC
  • non-root-project-monorepo > import.meta.url > should work during SSR
  • non-root-project-monorepo > import.meta.url > should work on client-side
  • non-root-project-monorepo > monorepo-package > should work during RSC
  • non-root-project-monorepo > monorepo-package > should work during SSR
  • non-root-project-monorepo > monorepo-package > should work on client-side
  • non-root-project-monorepo > source-maps > should work on RSC
  • non-root-project-monorepo > source-maps > should work on SSR
  • non-root-project-monorepo > source-maps > should work on client-side
Expand output

● non-root-project-monorepo › monorepo-package › should work during RSC

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  349 |     return setTimeout(() => {
  350 |       reject(
> 351 |         new Error(
      |         ^
  352 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  353 |         )
  354 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:351:9)

● non-root-project-monorepo › monorepo-package › should work during SSR

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  349 |     return setTimeout(() => {
  350 |       reject(
> 351 |         new Error(
      |         ^
  352 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  353 |         )
  354 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:351:9)

● non-root-project-monorepo › monorepo-package › should work on client-side

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  349 |     return setTimeout(() => {
  350 |       reject(
> 351 |         new Error(
      |         ^
  352 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  353 |         )
  354 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:351:9)

● non-root-project-monorepo › import.meta.url › should work during RSC

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  349 |     return setTimeout(() => {
  350 |       reject(
> 351 |         new Error(
      |         ^
  352 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  353 |         )
  354 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:351:9)

● non-root-project-monorepo › import.meta.url › should work during SSR

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  349 |     return setTimeout(() => {
  350 |       reject(
> 351 |         new Error(
      |         ^
  352 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  353 |         )
  354 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:351:9)

● non-root-project-monorepo › import.meta.url › should work on client-side

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  349 |     return setTimeout(() => {
  350 |       reject(
> 351 |         new Error(
      |         ^
  352 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  353 |         )
  354 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:351:9)

● non-root-project-monorepo › source-maps › should work on RSC

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  349 |     return setTimeout(() => {
  350 |       reject(
> 351 |         new Error(
      |         ^
  352 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  353 |         )
  354 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:351:9)

● non-root-project-monorepo › source-maps › should work on SSR

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  349 |     return setTimeout(() => {
  350 |       reject(
> 351 |         new Error(
      |         ^
  352 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  353 |         )
  354 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:351:9)

● non-root-project-monorepo › source-maps › should work on client-side

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  349 |     return setTimeout(() => {
  350 |       reject(
> 351 |         new Error(
      |         ^
  352 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  353 |         )
  354 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:351:9)

Read more about building and testing Next.js in contributing.md.

pnpm test-start test/production/graceful-shutdown/index.test.ts

  • Graceful Shutdown > production (standalone mode) > should not accept new requests during shutdown cleanup > when there is no activity
Expand output

● Graceful Shutdown › production (standalone mode) › should not accept new requests during shutdown cleanup › when there is no activity

expect(received).toEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

  Array [
-   0,
    null,
+   "SIGTERM",
  ]

  233 |
  234 |         // App finally shuts down
> 235 |         expect(await appKilledPromise).toEqual([0, null])
      |                                        ^
  236 |         expect(app.exitCode).toBe(0)
  237 |       })
  238 |     })

  at Object.toEqual (production/graceful-shutdown/index.test.ts:235:40)

Read more about building and testing Next.js in contributing.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants