Suggestion for change #22073
Open
Suggestion for change #22073
+21
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jszwedko
reviewed
Jan 2, 2025
There was a problem hiding this comment.
Hi @sharma-shray ,
Can you explain the intent of these changes? It is unclear to me.
Comment on lines
-295
to
+300
| // WARN: The paired `BufReader::consume` is not called intentionally. If we | ||
| // do we'll chop a decent part of the potential gzip stream off. | ||
| Ok(header_bytes.starts_with(GZIP_MAGIC)) | ||
| if header_bytes.starts_with(GZIP_MAGIC) { | ||
| r.consume(GZIP_MAGIC.len()); // To avoid interfering with the next read | ||
| Ok(true) | ||
| } else { | ||
| Ok(false) | ||
| } |
There was a problem hiding this comment.
I think this is wrong. is_gzipped should just be checking if the stream is gzip and not consuming any bytes, as the comment says.
Comment on lines
+267
to
-281
| // Load the current state of the tables (this is a lock-free operation). | ||
| let tables = tables.load(); | ||
| match **tables { | ||
| Some(ref tables) => { | ||
| let mut tables = tables.iter().fold(String::from("("), |mut s, (key, _)| { | ||
| s.push_str(key); | ||
| s.push_str(", "); | ||
| s | ||
| }); | ||
|
|
||
| tables.truncate(std::cmp::max(tables.len(), 0)); | ||
| tables.push(')'); | ||
|
|
||
| write!(f, "{} {}", name, tables) | ||
| // Check if the tables are loaded or still in the loading state. | ||
| match &**tables { | ||
| Some(ref tables) => { | ||
| // Map the keys to &str and join them with a comma. | ||
| let table_names = tables | ||
| .keys() | ||
| .map(|s| s.as_str()) | ||
| .collect::<Vec<_>>() | ||
| .join(", "); | ||
| write!(f, "{} ({})", name, table_names) | ||
| } | ||
| None => { | ||
| // If the tables are still loading, indicate the loading state. | ||
| write!(f, "{} loading", name) | ||
| } | ||
| None => write!(f, "{} loading", name), |
There was a problem hiding this comment.
What is the intent of this change?
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change Type
Is this a breaking change?
How did you test this PR?
Does this PR include user facing changes?
Checklist
Cargo.lock), pleaserun
dd-rust-license-tool writeto regenerate the license inventory and commit the changes (if any). More details here.References