-
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated BaseForm
tests to @testing-library/react
#1303
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1303 +/- ##
==========================================
- Coverage 94.66% 94.60% -0.06%
==========================================
Files 231 231
Lines 3821 3821
Branches 1029 1029
==========================================
- Hits 3617 3615 -2
Misses 82 82
- Partials 122 124 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know about the other it(...)
s but we definitely need to think that through.
I'm not sure how much we can count on the CodeCov code coverage.
If for example the autosave
functionality is covered somewhere else (e.g. in a theme package) then that's fine, but we can't lose the tested functionalities at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I haven't come up with any other tests so if nobody suggests anything we're good to go.
Is part of #1130
BaseForm
RTL suitesBaseForm
testsI cannot migrate most of
BaseForm
tests, because it was based onBaseForm
context or state. RTL doesn't support testing these cases. I didn't find another aproach to test these cases.Additional issue is with
ignores synchronous errors
test. Using RTL, error cannot be catched.