Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Simplify dashed return #15

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Enhancement: Simplify dashed return #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4e2a7c
Simplify dashed() return
shatterproof Jan 4, 2024
0ef3c93
Adjust dashed() comment copy
shatterproof Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Generator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ public function password(int $length = 16, bool $requireAll = false): string
}

/**
* Generate a random string of $length with lowercase and uppercase letters, and numbers, divided by $divider.
* Generate a random string of $length with lowercase and uppercase letters, and numbers, divided by $delimiter.
* This is suitable for use as a long random password that is easy to read and type.
*
* @param int $length
Expand All @@ -180,7 +180,7 @@ public function dashed(int $length = 25, string $delimiter = '-', int $chunkLeng
{
$string = $this->string($length, true, true, true, false, true);

return implode($delimiter, str_split($string, $chunkLength));
return wordwrap($string, $chunkLength, $delimiter, true);
}

/**
Expand Down