Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make selectbox invisible if its size is zero #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make selectbox invisible if its size is zero #88

wants to merge 1 commit into from

Conversation

zk-phi
Copy link

@zk-phi zk-phi commented Jun 5, 2020

This PR makes the Selectbox invisible by setting its display property to none, iff both width and height of the box is zero.

This avoids rendering a strange dot at the top-left position of the SelectableGroup.

スクリーンショット 2020-06-05 16 40 27

Thank you and regards.

@vercel
Copy link

vercel bot commented Jun 5, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/skymk1/react-selectable-fast/4gvmvde7g
✅ Preview: https://react-selectab-git-fork-zk-phi-avoid-rendering-zerowidth-31cb18.skymk1.now.sh

@JakeAngell
Copy link

@valerybugakov please merge, simple one line fix for annoying bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants