feat: add endpoint detection #2938
Conversation
|
Needs to be tested along with vaadin/flow#20567 in order to compile |
| return !classFinder.getAnnotatedClasses(Endpoint.class).isEmpty() | ||
| || !classFinder.getAnnotatedClasses(BrowserCallable.class) | ||
| .isEmpty(); |
There was a problem hiding this comment.
This check should probably exclude Hilla internal annotated classes, like SignalsHandler
There was a problem hiding this comment.
Excellent point, indeed, without this Flow would always try to generate the endpoints unless one completely excludes Hilla.
Something similar is needed:
ClassFinder classFinder = options.getClassFinder();
return Stream.concat(
classFinder.getAnnotatedClasses(Endpoint.class).stream(),
classFinder.getAnnotatedClasses(BrowserCallable.class).stream())
.anyMatch(annotatedClass -> !annotatedClass.getPackage().getName()
.startsWith("com.vaadin.hilla"));
| Assertions.fail("Class " + clazz.getName() | ||
| + " is annotated with @BrowserCallable or @Endpoint, but missing @InternalBrowserCallable."); |
There was a problem hiding this comment.
I think the assertion message is not correct here: in this case, all annotatedClasses will have @InternalBrowserCallable annotation, but they might miss @BrowserCallable or @Endpoint
There was a problem hiding this comment.
Probably the messages in the two tests are inverted
There was a problem hiding this comment.
Yes, they are inverted indeed, thanks for noticing it 👍
mshabarov
force-pushed
the
feat/endpoint-detection
branch
from
ed89b41 to
5e2e68c
Compare
|
|
This should be ready for review now, trying locally and it seems to pass on existing tests and new ones. |
Add check for if endpoint generator needs to run
Fixes vaadin/flow#20289
Fixes vaadin/flow#18800