Feature/make rosdep work #232
Open
+82
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MishkaMN
added
enhancement
adev4a
reviewed
Jan 17, 2025
noetic-foxy/package.xml
Outdated
| <depend condition="$ROS_VERSION == 1">xmlrpcpp</depend> | ||
|
|
||
| <!-- ROS 2 specific dependencies --> | ||
| <depend condition="$ROS_VERSION == 2">rclcpp</depend> |
There was a problem hiding this comment.
Looks like these packages are also available as debian distibutions, lets install them through apt like the other foxy packages
There was a problem hiding this comment.
removed the 2 ROS2 package (lifecycle is already included in ros-foxy-desktop)
however, rclcpp says just minimal ones, which I wasnt sure if it was exactly same, so I made sure to include it as ros-foxy-rclcpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
automotive_navigation_msgs was not installed on foxy where it should have from package.xml
This is when we realized foxy is not using rosdep to install packages.
This story is to divide the package.xml into ros1/ros2 to install them.
Humble removed the package.xml because it was not being used and its contents were being installed in the Dockerfile.
Related GitHub Issue
Related Jira Key
ARC-264
Motivation and Context
Issue encountered during rosbag2 recording issue where it stops recording once it detects a topic that the environment doesn't have the message type of
How Has This Been Tested?
Tried installding packages using the commands inside the container.
Types of changes
Checklist: