feat(Calendar): handle default slot of CalendarCellTrigger #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was started as a fix but correct fix is more like a feature.
CalendarCellTrigger is providing a slot but in case of using nested elements the logic in
handleClickwas failing becauseevent.targetdid not havedata-valueto get value from. Instead od reading from DOM a value fromprops.daymight be used which also simplifies logic.To further improve DX for such scenario
dayValueprop is added to the default scope. This will match behavior of CalendarHeading where year and month are provided.