perf: skip maxDepth filtering if natively supported
#560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
changed the title
maxDepth filtering if natively supported
Skips `maxDepth` filtering if _all_ drivers in the current storage instance natively support it (via the `maxDepth` flag). Also enables the `maxDepth` flag for `fs` and `fs-lite` drivers.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #560 +/- ##
==========================================
- Coverage 65.05% 60.01% -5.04%
==========================================
Files 39 42 +3
Lines 4055 3649 -406
Branches 487 590 +103
==========================================
- Hits 2638 2190 -448
- Misses 1408 1456 +48
+ Partials 9 3 -6 ☔ View full report in Codecov by Sentry. |
pi0
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skips
maxDepthfiltering if all drivers in the current storage instance natively support it (via themaxDepthflag).Also enables the
maxDepthflag forfsandfs-litedrivers.Depends on #551