Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove extra cli deps #538

Merged
merged 1 commit into from
Dec 25, 2024
Merged

build: remove extra cli deps #538

merged 1 commit into from
Dec 25, 2024

Conversation

bluwy
Copy link
Contributor

@bluwy bluwy commented Dec 25, 2024

src/cli.ts is no longer exported as a binary since 5dd3f9b. It uses citty and listhen which can both be moved as dev deps now.

@pi0
Copy link
Member

pi0 commented Dec 25, 2024

Oh nice find! Unstorage CLI drop was kinda unintended but considering it happened from 1.0.0 and no user demand I guess we can drop it.

@pi0 pi0 changed the title chore: move cli deps to dev deps chore: remove extra cli deps Dec 25, 2024
@pi0 pi0 changed the title chore: remove extra cli deps build: remove extra cli deps Dec 25, 2024
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.74%. Comparing base (4d61c78) to head (1ec7eab).
Report is 145 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #538      +/-   ##
==========================================
- Coverage   65.05%   58.74%   -6.31%     
==========================================
  Files          39       43       +4     
  Lines        4055     3636     -419     
  Branches      487      576      +89     
==========================================
- Hits         2638     2136     -502     
- Misses       1408     1496      +88     
+ Partials        9        4       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi0 pi0 merged commit 56fae44 into unjs:main Dec 25, 2024
3 of 4 checks passed
@bluwy bluwy deleted the move-cli-deps branch December 25, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants