Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error with not found occurrences on quotes combinations #7

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

fix error with not found occurrences on quotes combinations #7

wants to merge 11 commits into from
+8,428 −6,512

Conversation

abelpz
Copy link
Member

@abelpz abelpz commented Jan 7, 2025

Describe what your pull request addresses (Please include relevant issue numbers):

Please include detailed Test instructions for your pull request:

Standard Test Instructions for PR Review Process:

  • Double check unit tests that have been written
  • Check for documentation for code changes
  • Is the repo documentation accurate/appropriate?
    • Check Stylguidist if applicable
    • Check readme for correct information about the feature being worked on
  • Check that there are not inadvertent commits
  • Checkout the branch locally and ensure that app runs as expected
    • Ensure tests pass
    • Open and watch the console for errors
    • Make sure all actions perform as expected
    • Import and Load a new Project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Switch project to an existing project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Next time reverse the order of importing after loading an existing project
  • Reviewer should double check the DoD in the ISSUE, including the “spirit” of the story

@netlify Netlify
Copy link

netlify bot commented Jan 7, 2025 •
edited
Loading

❌ Deploy Preview for uw-quote-helpers failed. Why did it fail? →

Name Link
🔨 Latest commit f51ddeb
🔍 Latest deploy log https://app.netlify.com/sites/uw-quote-helpers/deploys/678a6f338d89bb00081c3be3

abelpz
abelpz commented Jan 14, 2025
View reviewed changes
Copy link
Member Author

@abelpz abelpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code solves the issue with finding multiple occurrences (occurrence number > 1) of more than one quote (ampersand separated quotes)

@abelpz abelpz requested a review from richmahn January 14, 2025 17:42
abelpz and others added 8 commits January 14, 2025 14:03
@abelpz
improved readme
49e5318
@abelpz
bumped package version
c17835c
@richmahn
Adds two test cases that fail
ed261b5
@abelpz
fix: source quote cleaning and multi-word quotes
e2bb7e2 
- Fix alignment issues caused by period mark
- Fix matching for quotes containing multiple words
@abelpz
Merge pull request #8 from unfoldingWord/richmahn-adds-two-tests
6ce4d68 
Adds two test cases that fail
@abelpz
bumped version
888e49f
@abelpz
Enhance quote handling and testing
8a9667f 
- Updated expected outputs in tests for consistency by removing unnecessary punctuation.
- Added new test cases for quotes from 1 Peter and 1 Corinthians to improve coverage.
- Modified `getTargetQuotesFromOrigWords` and `getTargetQuoteFromWords` functions to support an option for removing brackets from quotes.
- Introduced a new constant for the bracket removal pattern in `consts.js` to streamline text processing.
@abelpz
Bump version to 1.1.7 in package.json
f51ddeb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richmahn richmahn Awaiting requested review from richmahn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abelpz @richmahn