Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Accidental Publication of Unintended USFM Books and keep manifest file in master branch unaltered after release #201

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Prevent Accidental Publication of Unintended USFM Books and keep manifest file in master branch unaltered after release #201

merged 3 commits into from
Oct 1, 2024

Conversation

abelpz
Copy link
Member

@abelpz abelpz commented Sep 30, 2024 •
edited
Loading

Describe what your pull request addresses

Solves #199 and #202

Test Instructions

  • Open the release page in gatewayAdmin PR preview.
  • Mark the desired book files for release
  • Select either Literal Translation or Simplified Translation resources.
  • Complete the form as desired
  • Publish the release.
  • Verify that the marked USFM books or Previously released USFM book files are the only ones included in the published repo and manifest.yaml file in the master branch is not altered.

@abelpz abelpz linked an issue Sep 30, 2024 that may be closed by this pull request
Release Resource for scripture does not work for selected book #199
Closed
@netlify Netlify
Copy link

netlify bot commented Sep 30, 2024 •
edited
Loading

✅ Deploy Preview for gateway-admin ready!

Name Link
🔨 Latest commit 4bc018d
🔍 Latest deploy log https://app.netlify.com/sites/gateway-admin/deploys/66fc22e214984c0008bccb2d
😎 Deploy Preview https://deploy-preview-201--gateway-admin.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abelpz abelpz requested a review from richmahn September 30, 2024 19:35
@abelpz abelpz changed the title support usfm files to removal of books not in manifest Prevent Accidental Publication of Unintended USFM Books Sep 30, 2024
@abelpz abelpz changed the title Prevent Accidental Publication of Unintended USFM Books Prevent Accidental Publication of Unintended USFM Books and keep manifest file in master branch unaltered after release Oct 1, 2024
richmahn
richmahn approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@richmahn richmahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richmahn richmahn merged commit c34a78f into develop Oct 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richmahn richmahn richmahn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release Resource for scripture does not work for selected book
2 participants
@abelpz @richmahn