Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented sorting for media picker crops #17879

Open
wants to merge 2 commits into
base: v15/dev
Choose a base branch
from

Conversation

AndyButland
Copy link
Contributor

Prerequisites

  • I have added steps to test this contribution in the description below

Fixes #17829, tracked under AB 47498 (internal HQ tracker).

Description

The linked issue raises two points:

  1. Sorting is indicated by the presence of a "drag" icon, but it's not actually implemented.
  2. No message displays the need for the width and height.

I don't think there's anything to do for point 2. Whilst no message is displayed, you can't enter a new crop unless you provide all fields, so it's fairly clear the information needs to be provided, and is consistent with the other required fields of name and alias.

It should be possible to sort though, and when merged this PR will provide that functionality.

To Test:

  • Create a few crops on a media picker data type.
  • Verify that you can move the crop within the list by drag and drop.
  • Save the data type and verify that the moved items are persisted in the expected order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant