Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Github Actions for CI #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Github Actions for CI #42

wants to merge 2 commits into from

Conversation

doomspork
Copy link
Member

No description provided.

@doomspork
Copy link
Member Author

Need to sort out the Credo complaints and the test failures 🤔

@yordis yordis self-requested a review February 1, 2021 22:35
yordis
yordis requested changes Feb 1, 2021
View reviewed changes
Copy link
Member

@yordis yordis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops I meant to request changes,

CI is broken

@doomspork
Copy link
Member Author

I know 😁 I have to fix up the credo complaints and tests. I didn't get time today

@yordis
Copy link
Member

yordis commented Feb 2, 2021

Do we do it in this PR or as a follow up?

@doomspork
Copy link
Member Author

I'd rather get this PR passing before merging, the intent is to get the build passing and onto GitHub Actions.

I'll ping the team when this is ready for review 👍

@clupprich clupprich mentioned this pull request Jul 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yordis yordis yordis requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doomspork @yordis