WIP: Update Chisel from 6.5.0 to 7.0.0 #11
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tymcauley
force-pushed
the
update-chisel-7.x
branch
from
218579f to
28b609f
Compare
|
cc @jackkoenig, I brought this up a few weeks ago (regarding the transition from Chisel 6 to 7), but wanted to make sure it was still on your radar. |
jackkoenig
reviewed
Jan 6, 2025
Comment on lines
-329
to
-331
| override def connectFromBits(that: Bits)(implicit sourceInfo: SourceInfo): Unit = { | ||
| this.data := that.asTypeOf(this.data) | ||
| } | ||
|
|
There was a problem hiding this comment.
Noted by @tymcauley in Chisel dev meeting that this is the problem with upgrading to Chisel 7.
`UnknownWidth` became a `case object` in this Chisel PR: chipsalliance/chisel#4242 The `connectFromBits` method was removed in this Chisel PR: chipsalliance/chisel#4168
tymcauley
force-pushed
the
update-chisel-7.x
branch
from
28b609f to
ccaf0b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnknownWidthbecame acase objectin this Chisel PR: chipsalliance/chisel#4242The
connectFromBitsmethod was removed in this Chisel PR: chipsalliance/chisel#4168This update is causing the following test failure in
FixedPointSpec: