Debugging and logging fixes, reworked unpacking action #2827
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2827 +/- ##
==========================================
+ Coverage 82.58% 82.60% +0.02%
==========================================
Files 29 29
Lines 982 989 +7
==========================================
+ Hits 811 817 +6
- Misses 171 172 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
src/core/plugins/core/plugin.spec.js
Outdated
| group: "firmware", | ||
| files: [{ archive: "a.zip", dir: "a" }] | ||
| })); // TODO add assertions | ||
| // TODO add assertions |
There was a problem hiding this comment.
I don't think we should check exact params to the emits - imo we should test the functionality, not the implementation and I'd say the tests should not fail if we change the animation or wording on the messages - checking whether emit was called 3 times is enough I think?
There was a problem hiding this comment.
i followed the other tests. to actually test if it unpacks we would need to include a test file.
and if we just mock it all away, it kind of is useless as well?
not too common with tests, so will go the way you think is best.
There was a problem hiding this comment.
You should mock this unpack:
const { unpack } = require("../../helpers/asarLibs.js");
and then check if it was called with correct arguments
There was a problem hiding this comment.
Removed them and changed the todo message.
edit: we posted at almost the same time :D
will have a look at it, thanks!
There was a problem hiding this comment.
is it fine like this now?
[14899:0907/145232.866716:ERROR:node_bindings.cc(244)] Error parsing Node.js cli flags electron: [DEP0062]: `node --debug` and `node --debug-brk` are invalid. Please use `node --inspect` and `node --inspect-brk` instead. Change-Id: I1930db5382d8efb8454e0c2136e19a6cf1d07293 Signed-off-by: Alexander Martinz <[email protected]>
Before:
- debug: run killed with: {}
After:
- debug: run killed with: TypeError: Cannot read properties of undefined (reading 'condition')
Change-Id: I640cb5dc0070a66537bd0188cb108be1ab2f7e12
Signed-off-by: Alexander Martinz <[email protected]>
amartinz
force-pushed
the
misc-fixes
branch
5 times, most recently
from
eb3f5ab to
ef47f00
Compare
Unpacking actually expects the callback to always be provided, either as second or third argument. Change-Id: If81661d806ea58304c91d38a168535575ece8afd Co-developed-by: Maciej Sopyło <[email protected]> Signed-off-by: Alexander Martinz <[email protected]>
No description provided.