Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account not verified page #26

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Account not verified page #26

wants to merge 15 commits into from

Conversation

shailahaggarson
Copy link
Contributor

Simple page for 'Account not verified'

Copy link
Collaborator

@jjessieshang jjessieshang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Page looks great. The authentication flow has been implemented, so let's redirect unverified users directly to this page. Also merge in most recent changes from main.

@shailahaggarson shailahaggarson marked this pull request as draft November 30, 2024 20:21
@shailahaggarson shailahaggarson marked this pull request as ready for review December 7, 2024 00:25
Copy link
Collaborator

@jjessieshang jjessieshang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page redirect works for me! When I update this branch with the latest version of main, however, there are some styling conflicts that make the page narrower than the screen.
Screenshot 2024-12-06 at 5 06 11 PM

/* index.css */

/* Import Fonts */
@import url('https://fonts.googleapis.com/css2?family=Inter:wght@200;400;500;600;700&display=swap');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fonts should be defined in styles.css and used like variables here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why we have an html file in the backend, endpoints used by the frontend should be in the frontend/src/api directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants