Feature/autocomplete staff list no autocomplete

[andrewstec]

Description: A staff user would attempt to add another staff user and experience a permissions error where an Autocomplete component would attempt to fetch user information that the staff role should not have access to.

Fix: Enable autocorrect for the admin user role, but only allow manual entries for the staff user role.

Some questions that I had in the PR draft (answered in comment below):

• Is the filter working (and was it ever working) to filter out pre-existing users / admins
• Where else is Userautocomplete used and did my changes break anything? (cannot tell by tests at the moment)
• Do I need to connect and map the state to props in both components?
• Are the prop shapes necessary, or even the best prop option?
• Have the number of passing tests / failing tests changed?
• Write unit tests.

[andrewstec]

• Is the filter working (and was it ever working) to filter out pre-existing users / admins
  Tested on the master branch and it was not working. I am leaving the default behaviour.
• Where else is Userautocomplete used and did my changes break anything? (cannot tell by tests at the moment)
  Tested the add admin view, and it works.
  Do I need to connect and map the state to props in both components?
  Do not have to, but it keeps things less confusing instead of passing it down and up components
  Are the prop shapes necessary, or even the best prop option?
  They are theoretically necessary, but errors are not being thrown when implemented as they should be. I implemented the description of the properties that I am using.
  Have the number of passing tests / failing tests changed?
  Master Branch:
  
  Feature branch:
  
  Yes
• Fix unit tests.
  Yes, redefined parameters passed to back-end.
• Write unit tests.
  Done for User not found feature.

[winstan]

Looks good to me.