Piro: tempus/transient solver mods. #13692
Open
+199
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
AT: WIP
|
You seem to have created a PR on master. This is not allowed behavior, so we've blocked your PR. Please switch your PR to target the develop branch and remove the AT: WIP label. |
bartgol
removed
the
AT: WIP
bartgol
commented
Dec 23, 2024
bartgol
force-pushed
the
bartgol/piro-tempus-solver-mods
branch
from
88276b6 to
db96ee9
Compare
The base class already provides the empty implementation. For the end-integrator method, the base class actually provides more info on the cmd line... Signed-off-by: Luca Bertagna <[email protected]>
…dy compatible Signed-off-by: Luca Bertagna <[email protected]>
bartgol
force-pushed
the
bartgol/piro-tempus-solver-mods
branch
from
db96ee9 to
0d5dce5
Compare
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: bartgol |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
bartgol
force-pushed
the
bartgol/piro-tempus-solver-mods
branch
from
0d5dce5 to
ac4429d
Compare
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: bartgol |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
bartgol
force-pushed
the
bartgol/piro-tempus-solver-mods
branch
from
ac4429d to
fb36bb7
Compare
It is possible that X space has changed during integration, if mesh adaptation was used. In this case, warn the user, and have them taking care of this particular step. Note that all dgd* entries still cannot be computed for any response whose space is linked to the space of X. But the sensitivities in TransientSolver are only computed for responses 0,...,num_g-1, which do not include gx_out. All other responses require dgdx and dxdp, which are taken from the integrator (rather than from outArgs), so the underlying app can make sure they have the right space. Signed-off-by: Luca Bertagna <[email protected]>
Only one of the integrators is non-null, so this is well-defined Signed-off-by: Luca Bertagna <[email protected]>
bartgol
force-pushed
the
bartgol/piro-tempus-solver-mods
branch
from
fb36bb7 to
c352c63
Compare
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: bartgol |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
Signed-off-by: Luca Bertagna <[email protected]>
If TempusSolver is given an observer that is tempus-compatible, avoid creating a wrapper observer to pass to tempus Signed-off-by: Luca Bertagna <[email protected]>
bartgol
force-pushed
the
bartgol/piro-tempus-solver-mods
branch
from
c352c63 to
71b871d
Compare
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: bartgol |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two main things:
In TempusSolver, allow to pass the user-provided observer directly to the tempus integrator (if compatible). That is, if the user-provided
Piro::ObserverBasepointer also happens to inherit fromTempus::IntegratorObserverBasic, then don't create aObserverToTempusIntegrationObserverAdapter(to wrap it into a tempus-compatible one), but just use it directly. That is because the user-providedIn TransientSolver: avoid copying the final solution into the outArgs last response (a copy of the solution) if incompatible. This can happen if mesh adaptivity happened during the time integration. In this case, the gx_out response (the last response) would have a vector space corresponding to the initial mesh, which would not be compatible with the current solution. Since the input outArgs is const, and we can't "reset" a VectorBase space, we simply print a warning, and skip the copy, leaving it to the app to figure out how to retrieve the solution at the final time. Notice that every other response with vector space linked to that of X would also have some issue, but that's much harder to solve. Also, notice that sensitivities are only computed for "real" responses (not the dummy gx_out response); in the fwd case, they involve only dgdx and dxdp, which are retrieved from the model (rather than outArgs), so we assume the host app has the correct versions of these.
Remove pointless overrides for
Piro::ObserverToTempusIntegrationObserverAdaptermethods, since the impl in the base Tempus class is the same or better.Stakeholder Feedback
Albany development will require these mods in order for their mesh-adaptivity framework to work.
Testing
I added a unit test to verify that the solver uses the input observer "as-is", without wrapping in a
Piro::ObserverToTempusIntegratorObserverAdapterif it is already inheriting fromTempus::IntegratorObserver.