Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table class updates #834

Merged
merged 10 commits into from
Dec 2, 2023
Merged

fix: table class updates #834

merged 10 commits into from
Dec 2, 2023

Conversation

severinlandolt
Copy link
Member

Description

This PR improves the default styling and overflow behaviour of the table.

Related issue(s)

Closes #TBD

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has This been tested?

Storybook

Screenshots (if appropriate):

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

severinlandolt and others added 9 commits November 7, 2023 20:33
* add autofocus handler

* Fix selection height
* Expand children for SearchSelect  compatibility

* Expand children for Select compatibility

* Expand children for MultiSelect compatibility
* fix switch color

---------

Co-authored-by: Maxime BAUCHET <[email protected]>
Copy link

vercel bot commented Dec 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tremor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2023 11:36pm

@severinlandolt severinlandolt linked an issue Dec 1, 2023 that may be closed by this pull request
@severinlandolt severinlandolt changed the title chore: table class updates fix: table class updates Dec 1, 2023
@severinlandolt severinlandolt merged commit ddd997c into beta Dec 2, 2023
5 checks passed
Copy link

github-actions bot commented Dec 2, 2023

🎉 This PR is included in version 3.11.2-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Dec 2, 2023

🎉 This PR is included in version 3.12.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Dec 2, 2023

🎉 This PR is included in version 3.12.0-beta-package-updates.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 3.12.0-beta-customcolors.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@severinlandolt severinlandolt deleted the feat/table-improvements branch December 14, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Table: <table> cannot be targeted with className.
3 participants