feat: Add tooltip to switch component #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@severinlandolt Hey there! Can you review my PR? |
severinlandolt
added
the
PR: In Review
|
🎉 This PR is included in version 3.12.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.12.0-beta-package-updates.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.12.0-beta-customcolors.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
severinlandolt
added a commit
that referenced
this pull request
Dec 14, 2023
* feat: Add tooltip to switch component (#819) * chore: tracker facelift (#839) * feat: Custom Chart Color (#845) * feat: custom chart colors support within existing `colors` `prop` (#843) * Update tailwind.config.js * Update pull_request_template.md --------- Co-authored-by: motinados <[email protected]> Co-authored-by: Maxime BAUCHET <[email protected]> Co-authored-by: Adam <[email protected]> Co-authored-by: Rajdip Bhattacharya <[email protected]> Co-authored-by: christopherkindl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix issue #818 by adding a
tooltip?key to theSwitchcomponent.Switch.tsxfile to now allow atooltipkey in the propsRelated issue(s)
#818
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
How has This been tested?
I have used the Storybook to test the working.
Screenshots (if appropriate):
The PR fulfills these requirements:
mainbranch