Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: focus search input on Multiselect #782

Closed
wants to merge 18 commits into from

Conversation

mbauchet
Copy link
Collaborator

Description
add auto focus to input on Multiselect

Related issue(s)
#777

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has This been tested?

Screenshots (if appropriate):

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

mbauchet and others added 18 commits October 13, 2023 13:22
* fix ring color for date(range)picker

---------

Co-authored-by: Maxime BAUCHET <[email protected]>
* update recharts

* feat: added new interval props
* fix search issues on MultiSelect

- Add new value to keep availableOptions to search
- Reset the searchQuery when onBlur the list options
- Keep options selected when the user is searching
* add switch component

---------

Co-authored-by: Alexandre Rousseau <[email protected]>
Co-authored-by: mbauchet <[email protected]>
Co-authored-by: Severin Landolt <[email protected]>
@vercel
Copy link

vercel bot commented Oct 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tremor-storybook ✅ Ready (Inspect) Visit Preview Oct 29, 2023 4:26pm

@mbauchet mbauchet changed the base branch from main to beta October 29, 2023 16:26
@mbauchet mbauchet closed this Oct 29, 2023
@mbauchet mbauchet deleted the fix/focus-input-multiselect branch October 29, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants