Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New prop for x-axis label rotation #775

Merged
merged 3 commits into from
Oct 24, 2023
Merged

feat: New prop for x-axis label rotation #775

merged 3 commits into from
Oct 24, 2023

Conversation

severinlandolt
Copy link
Member

@severinlandolt severinlandolt commented Oct 24, 2023

Description

This PR adds a new rotateLabelX prop, giving the user control over the the necessary parameters to rotate the labels of the x-axis.

API:

rotateLabelX?: {
     angle: number;
     verticalShift:? number;
     xAxisHeight?: number;
   };

Related issue(s)

Closes #128

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has This been tested?

Screenshots (if appropriate):

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tremor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 4:04pm

@severinlandolt severinlandolt linked an issue Oct 24, 2023 that may be closed by this pull request
@severinlandolt severinlandolt changed the title fix: New prop for label rotation feat: New prop for label rotation Oct 24, 2023
@severinlandolt severinlandolt changed the title feat: New prop for label rotation feat: New prop for label rotation for x-axis Oct 24, 2023
@severinlandolt severinlandolt changed the title feat: New prop for label rotation for x-axis feat: New prop for x-axis label rotation Oct 24, 2023
@severinlandolt severinlandolt merged commit 416c2ab into beta Oct 24, 2023
14 checks passed
@github-actions
Copy link

🎉 This PR is included in version 3.11.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@severinlandolt severinlandolt deleted the feat/xangle branch October 30, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label rotation for x axis
1 participant