fix: implement proper download limit for uTP #6416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tearfur
added
scope:core
type:fix
tearfur
force-pushed
the
utp-download-limit
branch
3 times, most recently
from
3485674 to
bc25693
Compare
|
@tearfur commented in the libutp PR |
tearfur
removed
the
needs clarification
ckerr
approved these changes
Dec 24, 2023
ckerr
force-pushed
the
utp-download-limit
branch
from
bc25693 to
6629670
Compare
|
@tearfur OK to merge? |
|
@ckerr Go ahead. |
ckerr
force-pushed
the
utp-download-limit
branch
from
6629670 to
d1ca1d2
Compare
so that uTP acks can be sent out in a more timely fashion
ckerr
force-pushed
the
utp-download-limit
branch
from
d1ca1d2 to
e467225
Compare
ckerr
pushed a commit
that referenced
this pull request
Jan 2, 2024
* fix: return read buffer size in libutp read buffer size callback * refactor: clamp amount of data processed in `can_read_wrapper()` * chore: housekeeping * refactor: call `utp_read_drained()` in on-read callback so that uTP acks can be sent out in a more timely fashion
tearfur
added a commit
to tearfur/transmission
that referenced
this pull request
Jan 3, 2024
ckerr
pushed a commit
to tearfur/transmission
that referenced
this pull request
Jan 3, 2024
ckerr
pushed a commit
that referenced
this pull request
Jan 3, 2024
tearfur
added a commit
to tearfur/transmission
that referenced
this pull request
Jan 25, 2024
* fix: return read buffer size in libutp read buffer size callback * refactor: clamp amount of data processed in `can_read_wrapper()` * chore: housekeeping * refactor: call `utp_read_drained()` in on-read callback so that uTP acks can be sent out in a more timely fashion (cherry picked from commit 5000ede)
tearfur
added a commit
to tearfur/transmission
that referenced
this pull request
Jan 25, 2024
… (transmission#6481) (cherry picked from commit dce0d37)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of a series to fix #6361.
See the discussion and description of this PR series at part 1 transmission/libutp#15.