Add sha384 to sig auth

[cdr-chakotay]

Needed changes for signature authentication makeover.

Have had no rights in the repo, providing the patch like this now :)

@arnaudlimbourg @Acconut

[arnaudlimbourg]

@cdr-chakotay thanks!

Should there be support for more hashing algorithms? I'm wondering about the potential proliferation of boolean flags :)

[cdr-chakotay]

@cdr-chakotay thanks!

Should there be support for more hashing algorithms? I'm wondering about the potential proliferation of boolean flags :)

We are currently moving away from SHA1 to SHA384. To avoid issues during the transit I wanted the users to be able to fall back to SHA1 in case of emergency. This is why I added the flag :)

[Acconut]

I agree with @arnaudlimbourg. If we add an option to control the signature algorithm, it is better to have a non-boolean value for forward compatibility. Something like signature_algorithm = 'sha1' | 'sha384'

[arnaudlimbourg]

an Enum could work here, not sure whether it would add much value.

[cdr-chakotay]

We can also just swap to SHA384, as the current discussion lines out that it should not have a negative effect.

[Acconut]

We can also just swap to SHA384, as the current discussion lines out that it should not have a negative effect.

Yes, we have chosen that approach for most other SDKs now.

[cdr-chakotay]

Yeah, okay will update the PR is on my to-do :)

@arnaudlimbourg can you please add me to the SDK, so I do not need to fork it in my private repo in the future ?

[cdr-chakotay]

Hey any updates regarding this :)

[Acconut]

I just added you as a maintainer to this repo. Did it work?

[cdr-chakotay]

Yeah, worked out :) Do we want to merge this ?

[Acconut]

The change itself looks good, but I am a bit surprised that no changes to tests are needed to make CI pass. Do we not have any tests covering signature generation?

[cdr-chakotay]

The change itself looks good, but I am a bit surprised that no changes to tests are needed to make CI pass. Do we not have any tests covering signature generation?

Well I can certainly set up some or @arnaudlimbourg wants to do this :D?

[Acconut]

Feel free to give it a try!

[cdr-chakotay]

Migrated to internal PR 27