Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixed] Stone blobs will no longer take damage from fire #2311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mugg91
Copy link
Contributor

@mugg91 mugg91 commented Jan 12, 2025

Status

  • READY: this PR is (to the best of your knowledge) ready to be incorporated into the game.

Description

Fixes #2310

Stone doors, obstructors(solid, in the current dev build) and possibly other stone blobs could take fire damage, if an adjacent wood back tile starts burning if a fire arrow is shot at it and the fire arrow expires.

This PR fixing it by changing StoneStructorHit.as to set fire damage to 0.
With the damage being 0, Stone.as won't do a stone hit sound either.

Tested in online, works.

@mugg91
Copy link
Contributor Author

mugg91 commented Jan 12, 2025

Before

StoneDoorBug.mp4

After

StoneDoorFix.mp4

The fire cross is odd, I might change it later on (should only do fire cross if the fire arrow is picked or stepped on twice).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stone blobs can take fire damage
1 participant