Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixed] 3 Fireplace bugs #2290

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mugg91
Copy link
Contributor

@mugg91 mugg91 commented Jan 4, 2025

Status

  • READY: this PR is (to the best of your knowledge) ready to be incorporated into the game.

Description

This PR incorporates the fireplace fixes from #1848 while also incorporating the command changes from #1773

[fixed] Ingredient won't heal you and get cooked into a meal in fireplace at the same time
[fixed] Fireplace will remember if it has been extinguished when rejoining the server
[fixed] Many fireplaces overlapping each other making many foods from one ingredient

Fixes #1909
Fixes #1929
Fixes #2031

The "Cook ingredients by fire arrow" and "Chicken can be cooked by fire arrow" changes from #1848 were left out because I want to see the fireplace fixes added to the game soon and I can add those changes in a different PR later.

Reproduction Steps

  • Be low health
  • Stand inside a fireplace
  • Spawn a fishy via chat command
  • Notice it heals you and produces a cooked fish at the same time. After this PR, there won't be a cooked fish - You will get healed by the correct amount of health.
  • Join dedicated server
  • Spawn a few fireplaces and extinguish some of them
  • Rejoin
  • Notice all fireplaces will be burning. The ones that shouldn't be burning are kind of bugged, making a "shh" sound when an ingredient is thrown in but not actually cooking it, and igniting arrows into fake fire arrows. After this PR, when rejoining, the extinguished fireplaces will still be extinguished.
  • Spawn many fireplaces at the same place
  • Spawn a fishy
  • Notice many cooked fish will come out After this PR, only one cooked fish will come out.

@Vam-Jam Vam-Jam added the Sandbox PR that is focused towards Sandbox label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sandbox PR that is focused towards Sandbox
Projects
None yet
2 participants