[fixed] Bombs couldn't damage same team wires (TDM) #2260
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asumagic
reviewed
Jan 8, 2025
asumagic
requested changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Description
Fixes #2106
Components are given the tag "is component" and TDM gamemode checks for the tag in
onBlobCreated()to change components' team to neutral team (255).I made it so the sprite is reloaded in the previous team color, so we could use any team color we want. Some existing TDM maps use blue wires and I didn't want to change that to grey.
By setting team to 255, wires and components are now always damaged by bombs.
Previously, bombs wouldn't hurt wires of the same team.
I think this is much better than having to edit any map png files directly.
Tested in offline, works.