Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Careful version handling of Github releases and Adding rhub as apart of CI checks #249

Merged
merged 28 commits into from
Dec 20, 2024

Conversation

fontikar
Copy link
Collaborator

@fontikar fontikar commented Dec 18, 2024

Towards #248

Using rhub to configure GitHub Actions to help run tests on those more obscure runners (debian that CRAN requires.

I want to be able to first reproduce the errors that CRAN is flagging to determine:

  1. It is it spurious for load_taxonomic_resources to find a 0.0.2.9000 as a version number?
  2. Is it operating system specific for load_taxonomic_resources to find a 0.0.2.9000 as a version number?

dfalster and others added 26 commits May 6, 2024 17:22
* spelling fixes and removing special Mac install instructions

* adding mac back into CI
* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers
* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers

* Removed auto package version in citation

* Updated CRAN comments

* Fixed typo in CITATION

* Resubmitted

---------

Co-authored-by: Fonti Kar <[email protected]>
merging master back into develop to correct mistake
* fix example

* fix vignette paths
* dealing with cran and CI issues (#236)

* Bump version number (1.0.0.9000)

[skip ci]

* spelling fixes and removing special Mac install instructions (#229)

* spelling fixes and removing special Mac install instructions

* adding mac back into CI

* Cran preparations (#230)

* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers

* cleaning up (#231)

* Added example for default_version, updated LICENSE year, added R CMD CHECK results

* Comment about Tidy and Mac and HTML validation

* Updated CITATION file

* Updated version numbers

* Removed auto package version in citation

* Updated CRAN comments

* Fixed typo in CITATION

* Resubmitted

---------

Co-authored-by: Fonti Kar <[email protected]>

* fixing badges

* Tweaks (#234)

* fix example

* fix vignette paths

* testing for issue #235

* still working on #235

* one more try to find the edge case

* another edge case?

* reformat code in release file

* another edge case

* reverting previous commit to documentation

* adding check on resources to all functions that need resources

* bumping version number and updating readme

* missed two checking spots

---------

Co-authored-by: Daniel Falster <[email protected]>
Co-authored-by: Fonti Kar <[email protected]>
Co-authored-by: Dave Slager <[email protected]>

* Update new

* fixing bug in hidden function and re-naming a bit

* adding new genus in family function

* testing?

* namespaces

* testing testing

* forgot how namespaces work

* so many details *sigh*

---------

Co-authored-by: Daniel Falster <[email protected]>
Co-authored-by: Fonti Kar <[email protected]>
Co-authored-by: Dave Slager <[email protected]>
Merge branch 'master' into develop

# Conflicts:
#	NEWS.md
@fontikar
Copy link
Collaborator Author

I suppose I can use rhub without this PR and adding the workflow file in our package... https://r-hub.github.io/rhub/index.html#the-r-consortium-runners

Can try this first

@fontikar
Copy link
Collaborator Author

Error in `get_auth_header(email)`:
! Can't find token for email address "[email protected]".
ℹ Call `rhub::rc_new_token()` to get a token.
Type .Last.error to see the more details.
> rhub::rc_new_token()
→ R-hub tokens are stored at ~/Library/Application Support/rhub/validated_emails.csv.

── Choose email address to request token for (or 0 to exit) 

1: ✔  [email protected]
2:    [email protected]
3:    New email address

I think best to do this you @dfalster as you are maintainer, I can't submit on behalf of the maintainer and definitely don't want to create a random token!

@fontikar fontikar changed the title Adding rhub as apart of CI checks Careful version handling of Github releases and Adding rhub as apart of CI checks Dec 20, 2024
@fontikar fontikar merged commit b666e64 into master Dec 20, 2024
6 checks passed
@fontikar fontikar deleted the cran-fix branch December 20, 2024 03:37
fontikar added a commit that referenced this pull request Jan 13, 2025
* Added rhub checks as part of CI workflow

* Bumped version number

* Safe guarding versions that come in from github API  #248

* Added error message when bad versions #249

* Removing Shiny URL from README as it is currently down with Posit R package issue
fontikar added a commit that referenced this pull request Jan 16, 2025
Merge branch 'master' into develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants