-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Careful version handling of Github releases and Adding rhub as apart of CI checks #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
* spelling fixes and removing special Mac install instructions * adding mac back into CI
* Added example for default_version, updated LICENSE year, added R CMD CHECK results * Comment about Tidy and Mac and HTML validation * Updated CITATION file * Updated version numbers
* Added example for default_version, updated LICENSE year, added R CMD CHECK results * Comment about Tidy and Mac and HTML validation * Updated CITATION file * Updated version numbers * Removed auto package version in citation * Updated CRAN comments * Fixed typo in CITATION * Resubmitted --------- Co-authored-by: Fonti Kar <[email protected]>
merging master back into develop to correct mistake
* dealing with cran and CI issues (#236) * Bump version number (1.0.0.9000) [skip ci] * spelling fixes and removing special Mac install instructions (#229) * spelling fixes and removing special Mac install instructions * adding mac back into CI * Cran preparations (#230) * Added example for default_version, updated LICENSE year, added R CMD CHECK results * Comment about Tidy and Mac and HTML validation * Updated CITATION file * Updated version numbers * cleaning up (#231) * Added example for default_version, updated LICENSE year, added R CMD CHECK results * Comment about Tidy and Mac and HTML validation * Updated CITATION file * Updated version numbers * Removed auto package version in citation * Updated CRAN comments * Fixed typo in CITATION * Resubmitted --------- Co-authored-by: Fonti Kar <[email protected]> * fixing badges * Tweaks (#234) * fix example * fix vignette paths * testing for issue #235 * still working on #235 * one more try to find the edge case * another edge case? * reformat code in release file * another edge case * reverting previous commit to documentation * adding check on resources to all functions that need resources * bumping version number and updating readme * missed two checking spots --------- Co-authored-by: Daniel Falster <[email protected]> Co-authored-by: Fonti Kar <[email protected]> Co-authored-by: Dave Slager <[email protected]> * Update new * fixing bug in hidden function and re-naming a bit * adding new genus in family function * testing? * namespaces * testing testing * forgot how namespaces work * so many details *sigh* --------- Co-authored-by: Daniel Falster <[email protected]> Co-authored-by: Fonti Kar <[email protected]> Co-authored-by: Dave Slager <[email protected]>
Merge branch 'master' into develop # Conflicts: # NEWS.md
I suppose I can use rhub without this PR and adding the workflow file in our package... https://r-hub.github.io/rhub/index.html#the-r-consortium-runners Can try this first |
I think best to do this you @dfalster as you are maintainer, I can't submit on behalf of the maintainer and definitely don't want to create a random token! |
fontikar
changed the title
Adding rhub as apart of CI checks
Careful version handling of Github releases and Adding rhub as apart of CI checks
Dec 20, 2024
dfalster
approved these changes
Dec 20, 2024
fontikar
added a commit
that referenced
this pull request
Jan 16, 2025
Merge branch 'master' into develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #248
Using rhub to configure GitHub Actions to help run tests on those more obscure runners (debian that CRAN requires.
I want to be able to first reproduce the errors that CRAN is flagging to determine:
load_taxonomic_resources
to find a 0.0.2.9000 as a version number?load_taxonomic_resources
to find a 0.0.2.9000 as a version number?