Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected GitHub release tag name on Linux Debian OS #248

Open
fontikar opened this issue Dec 18, 2024 · 4 comments
Open

Unexpected GitHub release tag name on Linux Debian OS #248

fontikar opened this issue Dec 18, 2024 · 4 comments
Assignees

Comments

@fontikar
Copy link
Collaborator

fontikar commented Dec 18, 2024

Occasionally the taxonomic resources download fails. See Log: https://cran.r-project.org/web/checks/check_results_APCalign.html

When it fails, a few tests cannot run.

I'm not entirely sure if this is operating system specific OR its true Github server down. I suspect its the former since the other OS passed just fine.

I am tempted to skip all tests on linux... thoughts? its not failing on fedora clang or devl though so I am not sure how to best proceed!

Resources:
https://stackoverflow.com/questions/34691188/skip-all-testthat-tests-when-condition-not-met

https://stackoverflow.com/questions/58252422/how-to-retry-r-testthat-test-on-api-error

@fontikar fontikar self-assigned this Dec 18, 2024
@fontikar
Copy link
Collaborator Author

I've rubber ducky solved it.

This URL does not exist! "https://github.com/traitecoevo/APCalign/releases/download/0.0.2.9000"

Where the heck is version = "0.0.2.9000" coming from?

@fontikar
Copy link
Collaborator Author

fontikar commented Dec 18, 2024

The version number is either specified via the version argument otherwise it will default to default_version() which should be a date e.g. "2024-10-11"

0.0.2.9000 is a old versioning system we used to use (see #25)...

0.0.2.900 doesn't exist in our tags or releases https://github.com/traitecoevo/APCalign/tags

@fontikar
Copy link
Collaborator Author

Going to try run these tests again on rhub https://r-hub.github.io/rhub/index.html#usage

@fontikar
Copy link
Collaborator Author

fontikar commented Dec 20, 2024

Strategy discussed with @dfalster, quick fix to sort through the versions that come through the Github API and exclude any duplicates, rogue semantic versions and verify they remaining ones have date-like formats before returning the most recent release.

Once merged and sent back to CRAN, will slowly investigate what is going on using rhub, asking community for assistance and advice with a reprex :)

@fontikar fontikar changed the title Skip all tests if resources cannot be downloaded from Github Unexpected GitHub release tag name on Linux Debian OS Dec 20, 2024
fontikar added a commit that referenced this issue Dec 20, 2024
…of CI checks (#249)


* Added rhub checks as part of CI workflow

* Bumped version number

* Safe guarding versions that come in from github API  #248

* Added error message when bad versions #249
fontikar added a commit that referenced this issue Jan 13, 2025
* Added rhub checks as part of CI workflow

* Bumped version number

* Safe guarding versions that come in from github API  #248

* Added error message when bad versions #249

* Removing Shiny URL from README as it is currently down with Posit R package issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant