Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: github actions의 workflow jobs에 name 추가하여 통일화 #306

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Dec 9, 2024

Overview

  • github actions workflow에 name이 존재하는 경우도 있고, 그렇지 않은 경우도 있습니다. name 필드가 없는 것보다는 있는 것이 각 workflow가 어떤 작업을 수행하는지 명확히 알려준다고 판단하여 name 필드가 없는 jobs에 모두 name을 추가하여 통일합니다.

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

Copy link

changeset-bot bot commented Dec 9, 2024

⚠️ No Changeset found

Latest commit: 71d40ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 9:21am

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0896035) to head (71d40ca).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #306   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines          640       640           
  Branches       154       154           
=========================================
  Hits           640       640           

Copy link
Member

@okinawaa okinawaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!

@okinawaa okinawaa merged commit 8b90c82 into toss:main Dec 16, 2024
10 checks passed
@sukvvon sukvvon deleted the chore/add-name-in-workflows branch December 16, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants