Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): center peek and history dialog does not display custom fonts #9274

Open
wants to merge 2 commits into
base: canary
Choose a base branch
from

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Dec 24, 2024

close AF-1806

Copy link
Member Author

JimmFly commented Dec 24, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@JimmFly JimmFly marked this pull request as ready for review December 24, 2024 03:26
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.73%. Comparing base (09c7a59) to head (404966a).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9274      +/-   ##
==========================================
+ Coverage   52.71%   52.73%   +0.02%     
==========================================
  Files        2153     2153              
  Lines       97190    97190              
  Branches    16198    16198              
==========================================
+ Hits        51238    51258      +20     
+ Misses      44591    44571      -20     
  Partials     1361     1361              
Flag Coverage Δ
server-test 78.14% <ø> (+0.06%) ⬆️
unittest 32.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly force-pushed the jimmfly/1224/fix-center-pick branch from c46bd77 to ae889e2 Compare December 24, 2024 05:00
@JimmFly JimmFly requested a review from CatsJuice December 24, 2024 05:02
@JimmFly JimmFly changed the title fix(core): center peek does not display custom fonts fix(core): center peek and histroy dialog does not display custom fonts Dec 24, 2024
@JimmFly JimmFly changed the title fix(core): center peek and histroy dialog does not display custom fonts fix(core): center peek and history dialog does not display custom fonts Dec 24, 2024
<Slot
style={
{
'--affine-font-family': value,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only font?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can add new properties later if needed, but for now there is only a need for fonts.

@JimmFly JimmFly force-pushed the jimmfly/1224/fix-center-pick branch from ae889e2 to 404966a Compare January 6, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants