-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): center peek and history dialog does not display custom fonts #9274
base: canary
Are you sure you want to change the base?
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #9274 +/- ##
==========================================
+ Coverage 52.71% 52.73% +0.02%
==========================================
Files 2153 2153
Lines 97190 97190
Branches 16198 16198
==========================================
+ Hits 51238 51258 +20
+ Misses 44591 44571 -20
Partials 1361 1361
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
packages/frontend/core/src/modules/peek-view/view/doc-preview/doc-peek-view.tsx
Outdated
Show resolved
Hide resolved
c46bd77
to
ae889e2
Compare
<Slot | ||
style={ | ||
{ | ||
'--affine-font-family': value, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only font?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can add new properties later if needed, but for now there is only a need for fonts.
ae889e2
to
404966a
Compare
close AF-1806