Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pocount: add page & Spanish translation #15426

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

hasecilu
Copy link
Contributor

@hasecilu hasecilu commented Jan 2, 2025

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added new command Issues requesting creation of a new page or PRs adding a new page for a command. new translation PRs translating a page(s) from English to other languages. labels Jan 2, 2025
@tldr-bot
Copy link

tldr-bot commented Jan 2, 2025

The build for this PR failed with the following error(s):

pages/common/pocount.md:6: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/pocount.md:10: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/pocount.md:14: TLDR005 Example descriptions should end in a colon with no trailing characters
pages.es/common/pocount.md:6: TLDR005 Example descriptions should end in a colon with no trailing characters
pages.es/common/pocount.md:10: TLDR005 Example descriptions should end in a colon with no trailing characters
pages.es/common/pocount.md:14: TLDR005 Example descriptions should end in a colon with no trailing characters

Please fix the error(s) and push again.

@sebastiaanspeck
Copy link
Member

Please do not force-push the branches. This makes reviewing harder for us. In the end all commits will be squashed.

pages/common/pocount.md Outdated Show resolved Hide resolved
pages/common/pocount.md Outdated Show resolved Hide resolved
hasecilu and others added 2 commits January 3, 2025 14:46
Co-authored-by: Sebastiaan Speck <[email protected]>
Co-authored-by: Sebastiaan Speck <[email protected]>
@tldr-bot
Copy link

tldr-bot commented Jan 3, 2025

Hello! I've noticed something unusual when checking this PR:

  • The page pages.es/common/pocount.md is outdated, based on the command contents itself, compared to the English page.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.


- Imprime una tabla colorida con el progreso de la traducción de un archivo:

`pocount {{ruta/a/archivo.po}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`pocount {{ruta/a/archivo.po}}`
`pocount {{ruta/al/archivo.po}}`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your first and original proposal to tldr must be merged, then do the translation to the language you domain.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, should be on different PRs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 337 coincidences for "ruta/a/" and 985 for "ruta/al/" should a PR changing first form be done?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first, the original pull request of the english command must be merged, then, once is merged do your proposal of spanish translation

pages.es/common/pocount.md Outdated Show resolved Hide resolved
hasecilu and others added 2 commits January 3, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command. new translation PRs translating a page(s) from English to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants