Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix getproxyurl for urls without a prefix #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

plooshi
Copy link

@plooshi plooshi commented Dec 5, 2024

No description provided.

@wearrrrr
Copy link
Member

wearrrrr commented Dec 5, 2024

Shouldn't the above line already handle this edge case? I'm a little bit confused at what needs to be fixed here

@wearrrrr
Copy link
Member

wearrrrr commented Dec 5, 2024

Oh wait, I see what you're going for. You might need to move it above the check for URL.isUrl though, I'll test it out later.

@plooshi
Copy link
Author

plooshi commented Dec 5, 2024

i've just made it so it's the same logic as the embed option

@plooshi
Copy link
Author

plooshi commented Dec 5, 2024

the point is so that if you type something like discord.com it will add http:// before it, so that UV doesn't say invalid url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants