Fix TAM handling in update script #7617
Merged
+38
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akuzm
approved these changes
Jan 23, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7617 +/- ##
==========================================
+ Coverage 80.06% 82.28% +2.21%
==========================================
Files 190 239 +49
Lines 37181 44171 +6990
Branches 9450 11104 +1654
==========================================
+ Hits 29770 36345 +6575
- Misses 2997 3437 +440
+ Partials 4414 4389 -25 ☔ View full report in Codecov by Sentry. |
fabriziomello
approved these changes
Jan 23, 2025
svenklemm
force-pushed
the
update_script_tam
branch
18 times, most recently
from
4dbcfbc to
ea0a368
Compare
We need to allow these in the update script as we try to create an operator class later that is gonna call those functions during upgrade process.
svenklemm
force-pushed
the
update_script_tam
branch
2 times, most recently
from
fde95ff to
ba5e66a
Compare
The TAM SQL code was not written with update and downgrade scripts in mind prevents further releases past 2.18.0 due to not splitting up the parts that need to be part of every update script and those that can only run once during initial installation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TAM SQL code was not written with update and downgrade scripts
in mind prevents further releases past 2.18.0 due to not splitting
up the parts that need to be part of every update script and those
that can only run once during initial installation.
Disable-check: force-changelog-file
Disable-check: commit-count