Disable deadlock permutations in merge chunks tests #7595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The merge chunks functionality can use a "lock upgrade" approach that allows reads during the merge. However, this is not the default approach since it can lead to deadlocks. Some isolation test permutations were added to illustrate deadlocks for the "lock upgrade" approach, but since it can lead to either process being killed the test output is not deterministic. Also add two new permutations for the non-lock-upgrade approach that show it does not deadlock for concurrent reads and writes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7595 +/- ##
==========================================
+ Coverage 80.06% 82.24% +2.17%
==========================================
Files 190 238 +48
Lines 37181 44139 +6958
Branches 9450 11101 +1651
==========================================
+ Hits 29770 36300 +6530
- Misses 2997 3451 +454
+ Partials 4414 4388 -26 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The merge chunks functionality can use a "lock upgrade" approach that allows reads during the merge. However, this is not the default approach since it can lead to deadlocks. Some isolation test permutations were added to illustrate deadlocks for the "lock upgrade" approach, but since it can lead to either process being killed the test output is not deterministic.
Also add two new permutations for the non-lock-upgrade approach that show it does not deadlock for concurrent reads and writes.
Disable-check: force-changelog-file